Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bitbucket sync #3198

Merged
merged 10 commits into from
Nov 11, 2024
Merged

Fix bitbucket sync #3198

merged 10 commits into from
Nov 11, 2024

Conversation

akshay-gupta7
Copy link
Contributor

@akshay-gupta7 akshay-gupta7 commented Nov 4, 2024

Why does this PR exist?

Fixes #3196

What does this pull request do?

This PR increases the amount of json files returned to 100, which is the maximum allowed from their API.
The default was 10, hence the users were unable to fetch the set json files, when the number of sets was beyond 10.

Testing this change

  • Create a token set subfolder with more than 10 sets.
  • Push it to Bitbucket.
  • Then pull it from the same repo.
  • Now it will should be pulling all the sets(unless the count is more than 100)

Additional Notes (if any)

@akshay-gupta7 akshay-gupta7 self-assigned this Nov 4, 2024
Copy link

changeset-bot bot commented Nov 4, 2024

🦋 Changeset detected

Latest commit: 619d739

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 4, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Commit SHA:de5c2c4440e75bcce8f71ceaeb8a458743ea6f4f

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-bitbucket-sync 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 67.08 (0.13) 57.74 (0.03) 63.86 (0.1) 67.42 (0.13)
🟢 packages/tokens-studio-for-figma/src/storage/BitbucketTokenStorage.ts 79.78 (17.56) 60.78 (5.68) 72.72 (13.63) 79.12 (17.06)

github-advanced-security[bot]

This comment was marked as resolved.

Copy link
Collaborator

@six7 six7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@akshay-gupta7 akshay-gupta7 merged commit 1af628f into main Nov 11, 2024
11 checks passed
@akshay-gupta7 akshay-gupta7 deleted the fix-bitbucket-sync branch November 11, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BitBucket syncing issue
2 participants